fix: deselecting group chip reselects All teams#543
Open
piyush140104 wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Open
fix: deselecting group chip reselects All teams#543piyush140104 wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
piyush140104 wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the heatmap page, once a team group chip (e.g. Customer, Internal) is selected there is no way to deselect it. Clicking it again does nothing and the chip stays permanently stuck in the selected state.
Root Cause
In toggleTeamGroupFilter() inside circular-heatmap.component.ts, the else branch which runs when the chip is already selected only had a console.log and returned immediately. There was no deselection logic.
Fix
Replaced chip.toggleSelected() calls with data driven logic using filtersTeamGroups as the single source of truth since the template already binds [selected] to filtersTeamGroups[group.key]. Selecting a group chip now deselects all other group chips first. Deselecting a group chip clears all team filters, resets hasTeamsFilter and automatically reselects the All teams chip. setVisibleTeams() is now called once after the loop instead of inside it.
Reviewers
@vbakke @wurstbrot
Closes #524